Conversation
…equest. Adds UI to import ontologies from json by upload, following changes to figma design
There was a problem hiding this comment.
Pull Request Overview
This pull request implements new API endpoints for ontology creation and enhances the ontology creation UI, including file import support and updated status dialogs, while also refining the organization and fork components.
- Added new endpoints for creating ontologies and retrieving tokens in the API service.
- Enhanced the AddNewOntologyDialog component with file and URL handling, along with UI tab switches between manual input and file import.
- Updated several UI components (OrganizationsList, StatusDialog, CreateForkDialog) to improve consistency and user experience.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.js | Added new proxy configuration and logging for ontology spec requests. |
| src/config.js | Introduced new API endpoint keys for ontology and token management. |
| src/components/organizations/index.jsx | Updated UI styling and user condition checks. |
| src/components/common/StatusDialog.jsx | Enhanced dialog to conditionally render an error state background. |
| src/components/common/OrganizationsList.jsx | Refactored layout and navigation logic for organizations. |
| src/components/TermEditor/ImportFile.jsx | Extended file input acceptance to include JSON files. |
| src/components/SingleOrganization/index.jsx | Temporarily commented out fetchData call. |
| src/components/SingleOrganization/CreateForkDialog.jsx | Removed unused state and commented-out API call code. |
| src/components/SingleOrganization/AddNewOntologyDialog.jsx | Added file import and tab navigation for ontology creation along with improved status handling. |
| src/api/endpoints/apiService.ts | New API functions for ontology creation and token retrieval added. |
#116 - removing unused fetchdata call Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Remove Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ddelpiano
approved these changes
Jun 12, 2025
Member
ddelpiano
left a comment
ddelpiano
left a comment
There was a problem hiding this comment.
Approving this since the html parsing will be tackled as technical debt in another card ILEX-125, but all the rest looks good and this will allow us to move forward with the active ontologies flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new features and enhancements, primarily focused on ontology creation, file import functionality, and UI improvements. The most significant changes include the addition of new API endpoints for ontology creation and token retrieval, updates to the
AddNewOntologyDialogcomponent to support file-based ontology creation, and UI refinements across multiple components.API Enhancements
createNewOntology,getNewTokenApi, andretrieveTokenApifunctions insrc/api/endpoints/apiService.tsto enable ontology creation and token retrieval. These endpoints handle POST and GET requests with appropriate headers and data structures.Ontology Creation Features
AddNewOntologyDialogcomponent:ImportFileTabcomponent. Added state management for files, URL, and tab selection. [1] [2] [3] [4]UI Improvements
OrganizationsListcomponent:StatusDialogcomponent:StatusErrorBackgroundPattern) for failed operations. Updated prop types to include anerroredflag. [1] [2] [3] [4] [5]File Import Functionality
ImportFilecomponent to support.jsonfiles alongside.csv. Added logic to parse JSON files and handle invalid content gracefully.These changes collectively enhance the application's ontology management capabilities, improve user experience, and streamline the UI for better usability.